search

jazzband / django-hosts

Dynamic and static host resolving for Django. Maps hostnames to URLconfs.
http://django-hosts.rtfd.org
Other
982 stars 106 forks source link

fix for django 3.1 middleware #122

Closed ghost closed 2 years ago

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b208cdced4e20bd076cd5066d5fc0306741a155f on kojibhy:fix-3.1-middleware into 3b7a9545c63ed7799c2d79c4b241cd34d08377fb on jazzband:master.

an7oine commented 3 years ago

Django MiddlewareMixin does this already

LeMinaw commented 3 years ago

Django MiddlewareMixin does this already

Just to point out Django's MiddlewareMixin sets async_capable = True by default.

However, I see no reason preventing django-hosts middleware to be async-capable

ddabble commented 2 years ago

126 implements a better-suited solution for what seems to be the motivation behind this PR 🤔 Does it solve the same problem you were trying to solve, @kojibhy? In that case, we can close this PR if the other one is merged 🙂