jazzband / django-hosts

Dynamic and static host resolving for Django. Maps hostnames to URLconfs.
http://django-hosts.rtfd.org
Other
982 stars 106 forks source link

better syntax highlighting #145

Closed bashu closed 2 years ago

bashu commented 2 years ago

to @daadu here it is

daadu commented 2 years ago

Any reason I am referred?

bashu commented 2 years ago

to @daadu I am sorry, I have mistyped @ddabble username πŸ€¦β€β™‚οΈ

bashu commented 2 years ago

to @ddabble here it is

codecov[bot] commented 2 years ago

Codecov Report

Merging #145 (77da570) into master (bae7c03) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #145   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          399       399           
  Branches        67        67           
=========================================
  Hits           399       399           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update bae7c03...77da570. Read the comment docs.

timgraham commented 2 years ago

My experience working with Django's docs is that unnecessary to use .. code-block:: python because python is Sphinx's default.

Btw, @ddabble please use squash and merge or rebase and merge to keep Git's history free of merge commits. Thanks.

ddabble commented 2 years ago

My experience working with Django's docs is that unnecessary to use .. code-block:: python because python is Sphinx's default.

That's fair, but at least now it's explicit, and it also looks better on GitHub πŸ‘Œ

Btw, @ddabble please use squash and merge or rebase and merge to keep Git's history free of merge commits. Thanks.

Alright, thanks for making me aware of that, I'll keep it in mind 😊