#19 -- POC, loop over all hosts.

jazzband / django-hosts

Dynamic and static host resolving for Django. Maps hostnames to URLconfs.

http://django-hosts.rtfd.org

Other

982 stars 106 forks source link

#19 -- POC, loop over all hosts. #20

Closed apollo13 closed 8 years ago

apollo13 commented 9 years ago

The PR is mostly so Travis can run through it

jezdez commented 9 years ago

I think we should make that feature opt-out. It's just to big of a departure of the current system and I'm afraid of hard to debug errors that may be swallowed up by Django's reversal system. Maybe introduce a HOST_STICKY or something?

jezdez commented 9 years ago

If the "looping" feature should be enabled by default HOST_STICKY needs to default to False since that implies that the host resolving sticks to the explicitly provided hostname.

apollo13 commented 9 years ago

Not sure if HOST_STICKY is the best name then ;) HOST_REVERSE_LOOPING maybe? I know it is long, but should describe the intent better.

jezdez commented 9 years ago

@apollo13 That's equally confusing since it could mean that the looping is done in reverse ;)

apollo13 commented 9 years ago

Looping is done in reverse...

On Fri, Jan 9, 2015, 18:14 Jannis Leidel notifications@github.com wrote:

@apollo13 https://github.com/apollo13 That's equally confusing since it could mean that the looping is done in reverse ;)

— Reply to this email directly or view it on GitHub https://github.com/jezdez/django-hosts/pull/20#issuecomment-69365705.

apollo13 commented 9 years ago

@jezdez read the above as: I'll implement whatever you want, just tell me what you want ;)

On Fri, Jan 9, 2015, 18:16 Florian Apolloner florian@apolloner.eu wrote:

Looping is done in reverse...

On Fri, Jan 9, 2015, 18:14 Jannis Leidel notifications@github.com wrote:

@apollo13 https://github.com/apollo13 That's equally confusing since it could mean that the looping is done in reverse ;)

— Reply to this email directly or view it on GitHub https://github.com/jezdez/django-hosts/pull/20#issuecomment-69365705.

jezdez commented 9 years ago

Ok, this needs a few things to be complete:

A non-confusing setting name that takes current behavior into account (opt-in or opt-out?)
A plan for deprecation (if needed) for the current behavior
Raising exceptions if it find ambiguous host names like the ones that take parameters
A migration guide for the docs with noob-friendly explanation what changes

timgraham commented 8 years ago

Closing due to inactivity.