search

jazzband / django-hosts

Dynamic and static host resolving for Django. Maps hostnames to URLconfs.
http://django-hosts.rtfd.org
Other
982 stars 106 forks source link

resolvers.reverse not pointing to domain, am I doing something wrong? #38

Closed int-ua closed 9 years ago

int-ua commented 9 years ago

Django 1.8.2, django-hosts 1.2

Config:

host_patterns = patterns('',
    host(r'', 'project.urls', name='root'),
    host(r'www', 'project.urls', name='www'),
...

Django shell example:

>>> from django_hosts.resolvers import reverse
>>> reverse("namespace:view", kwargs={'arg':8, 'pk':1}, host='www')
'//www/arg8/pk/1/'
>>> reverse("namespace:view", kwargs={'arg':8, 'pk':1}, host='root')
'///arg8/pk/1/'

Why isn't it //www.domain.com/arg8/pk/1/?

int-ua commented 9 years ago

Ok, adding

PARENT_HOST = ALLOWED_HOSTS[0]

to the settings.py helped. What do you think about defaulting PARENT_HOST to ALLOWED_HOSTS[0]? Looks reasonable to me.