search

jazzband / django-hosts

Dynamic and static host resolving for Django. Maps hostnames to URLconfs.
http://django-hosts.rtfd.org
Other
982 stars 106 forks source link

Fixes #57 #58

Closed bretth closed 8 years ago

bretth commented 8 years ago

This might be a little naive, but I figured following the django support timeline and moving all the affected code into a separate module seems better than breaking backward compatibility.

jezdez commented 8 years ago

@bretth Nah, that's a good idea in general, thanks!

timgraham commented 8 years ago

Thanks for working on this and sorry I didn't see the PR until now. Let me know if you want to work on the improvements, otherwise I can pick it up.

bretth commented 8 years ago

You're welcome to improve it Tim, I just did enough to make it pass all the existing tests with 1.10 inserted into the mix (can_fail was one of those things).

timgraham commented 8 years ago

Okay, have proposed updates for my comments in https://github.com/jazzband/django-hosts/pull/59. Please review if you like.