jazzband / django-hosts

Dynamic and static host resolving for Django. Maps hostnames to URLconfs.
http://django-hosts.rtfd.org
Other
982 stars 106 forks source link

settings.APPEND_SLASH is ignored on subdomains #63

Open lampslave opened 7 years ago

lampslave commented 7 years ago

Django raises 404 on http://subdomain.mydomain.com/mypage while http://subdomain.mydomain.com/mypage/ works as expected.

Pattern: r'^mypage/$' Version: 1.4 Django: 1.8 Middleware order:

MIDDLEWARE_CLASSES = (
    'django.contrib.sessions.middleware.SessionMiddleware',
    'django.middleware.common.CommonMiddleware',
    'django.middleware.csrf.CsrfViewMiddleware',
    'django.contrib.auth.middleware.AuthenticationMiddleware',
    'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
    'django.contrib.messages.middleware.MessageMiddleware',
    'django.middleware.clickjacking.XFrameOptionsMiddleware',
    'django.middleware.security.SecurityMiddleware',

    'django_hosts.middleware.HostsRequestMiddleware',

    'mymiddleware',

    'django_hosts.middleware.HostsResponseMiddleware',
)
bak1an commented 7 years ago

@lampslave Try moving django_hosts.middleware.HostsRequestMiddleware to be before django.middleware.common.CommonMiddleware

hheimbuerger commented 5 years ago

Possibly related: it appears that django-hosts' reverse() function does not generate URLs with trailing slashes if APPEND_SLASH is set, while Django's reverse() function does so.