Closed blag closed 9 months ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
dde3307
) 64.34% compared to head (51e481e
) 65.71%.
Files | Patch % | Lines |
---|---|---|
invitations/views.py | 82.60% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
pre-commit.ci autofix
Hi @blag
Nice work! :clap:
Python 3.7 has been dropped in 2.1.0 - so we can revert the mentioned commit :blush:
Also there is a conflict.
I'll approve and merge when those issues are resolved :+1:
Removed commit and fixed conflict.
Hey @valberg, thanks for the merge.
Do you mind tagging a release? I have a project that needs my fix and I'd like to specify a version instead of a commit hash for it. 😄
Fixes #231.
Pass through a
next=...
query parameter to the signup and login views.The docs for
SIGNUP_REDIRECT
andLOGIN_REDIRECT
indicate they should be a URL name, the default values for these settings are URL names, and the tests for the allauth backend do not override those options and so expect a URL name.But the tests for the basic backend override that option with a direct URL:
Which is why I do this in this PR:
Fixing this may not be backwards compatible with existing users. It is also best left for a separate discussion, so for this PR I allowed for both options.
I also removed the walrus operator in a separate commit, so once we drop support for Python 3.7 we can revert that single commit to use the walrus operator.