Test Django 5.0 - Githubissues

jazzband / django-model-utils

Django model mixins and utilities.

https://django-model-utils.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.66k stars 365 forks source link

Test Django 5.0 #583

Closed adamchainz closed 7 months ago

adamchainz commented 11 months ago

Problem

Test the new version of Django that’s in beta.

Depends on #582. If you want to consider updating SaveSignalHandlingModel, we can look at that, but I really suggest that it be removed.

Solution

Added classifier to setup.py, new test environment to tox.ini, setup, and upgraded test requirements to fix some warnings.

Commandments

[x] Write PEP8 compliant code.
[x] Cover it with tests.
[x] Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
[x] Pay attention to backward compatibility, or if it breaks it, explain why.
[x] Update documentation (if relevant).

adamchainz commented 11 months ago

Apologies for the initially wrong title, that will have caused duplicate-looking threads on email.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (74a064d) 95.10% compared to head (2708023) 95.10%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #583 +/- ## ======================================= Coverage 95.10% 95.10% ======================================= Files 6 6 Lines 796 796 ======================================= Hits 757 757 Misses 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shanx commented 8 months ago

Hey @adamchainz could you possible merge master into your branch and update the django 5.0 version to the release one. Then I would say let's go ahead with merging this PR.

adamchainz commented 8 months ago

I rebased rather than merging, but yes now it’s up to date!

shanx commented 7 months ago

Hey @adamchainz thanks for the work. I just merged your PR and tried to push a new release to pypi. It seems there is a release gh workflow: https://github.com/jazzband/django-model-utils/actions/runs/7856043884/job/21438400809 but it doesn't seem to work. Do you happen to know more?

adamchainz commented 7 months ago

I have no idea, sorry. I'm no maintainer.

shanx commented 7 months ago

hey @carljm, are you the original author of this library? After merging Adam's work I tried to push out a new release, but it looks like the release script doesn't fully work anymore: https://github.com/jazzband/django-model-utils/actions/runs/7856043884/job/21438400809 do you have any idea wat could go wrong here?

carljm commented 7 months ago

@shanx I am the original author, but I have neither used the project nor been involved in maintenance for at least 8 years. I'm afraid I don't know anything about how that publish script works or what went wrong with it. I am willing to collaborate as needed in handoff steps to a responsible maintainer, but beyond that I don't have any interest in maintaining django-model-utils. Sorry!

shanx commented 7 months ago

I totally understand that @carljm. I thought the spend a bit of time on this, get a release out there. But also don't have time to really dive into things. I see jazzband has the possibility to get help on a new release to pypi, I'll give that a shot. Anyway thanks for answering and have a beautiful day.

shanx commented 7 months ago

@adamchainz a release was just pushed to pypi by @charettes. Thanks everyone!