search

jazzband / django-model-utils

Django model mixins and utilities.
https://django-model-utils.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.66k stars 365 forks source link

Minor cleanup of the code handling `UrlsafeTokenField`'s `factory` argument #607

Closed mthuurne closed 6 months ago

mthuurne commented 6 months ago

The use of isinstance(factory, Callable) is avoided, because it triggers a long standing bug in mypy.

Additionally, a wrong word in an error message was fixed.

This should have no impact on users of the library.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.57%. Comparing base (994d6c1) to head (6c5ed66).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #607 +/- ## ========================================== - Coverage 98.57% 98.57% -0.01% ========================================== Files 6 6 Lines 773 772 -1 ========================================== - Hits 762 761 -1 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.