search

jazzband / django-mongonaut

Built from scratch to replicate some of the Django admin functionality and add some more, to serve as an introspective interface for Django and Mongo.
MIT License
240 stars 67 forks source link

Patched for Python 3 #66

Closed haard closed 10 years ago

haard commented 10 years ago

Added 2to3 to setup.py and did the simplest patch possible for the updated ImportError message in Python 3. Tests pass on Python 3.3, happy-testing the UI seems to work.

garrypolley commented 10 years ago

I'll give it a :+1:. I'll wait a day or 2 and merge this if @pydanny has no objections.

Thanks for the patch.

pydanny commented 10 years ago

Unfortunately, I suspect this is going to fail. I've done enough Python 2/3 compat work to know there is enough in the code base to make 2to3 not operate very well. So what I'm going to do is add Python 3 to the travis.yml file and see what happens in the tests.

haard commented 10 years ago

I expect there'll pop up more errors, but I'll fix and contribute them as I find them. The build scripts (e.g. installing unittest2) is a problem for CI builds right now.

pydanny commented 10 years ago

Yeah, Travis fails out. :P

haard commented 10 years ago

Is it possible to run build steps conditionally on version, or ignore the error? The actual tests does run on 3.3

pydanny commented 10 years ago

I did something like that in dj-stripe. Having trouble paying with me phone. :(

pydanny commented 10 years ago

Looks like you got it figured out. I added the Python 3 classified and bumped the version on PyPI. This way it will show up on Django Packages as being Python 3 compliant. People will try it and report errors. Ah yes...beta indeed. :wink: