search

jazzband / django-mongonaut

Built from scratch to replicate some of the Django admin functionality and add some more, to serve as an introspective interface for Django and Mongo.
MIT License
240 stars 67 forks source link

added '{% load url from future %}' in templates for backward compatibility #68

Closed ragingneuron closed 10 years ago

ragingneuron commented 10 years ago

added '{% load url from future %}' in templates for backward compatibility with django 1.4 and before, for more info checkout django 1.5 changelog. Summarising the same: if you are not using {% load url from future %} in your templates, you’ll need to change tags like {% url myview %} to {% url "myview" %}. If you were using {% load url from future %} you can simply remove that line under Django 1.5

garrypolley commented 10 years ago

:+1:

garrypolley commented 10 years ago

I'll merge this in a bit once it's had a few hours to be seen. After that I'm sure @pydanny can get a new version released once it's merged to master.

pydanny commented 10 years ago

:+1:

I'll push to PyPI after it's merged.

garrypolley commented 10 years ago

Should be ready to go. Let me know if I missed anything @pydanny

https://github.com/pydanny/django-mongonaut/commit/e8176e6ceac3c2e91f421b6e397888087ea1868d

ragingneuron commented 10 years ago

thanks for including my contribution FYI, there are typos and inconsistent date format in file 'CHANGELOG.rst', plus aren't you supposed to update the file 'README.rst' for current version

pydanny commented 10 years ago

Just pushed up to PyPI.

ShipraShalini commented 8 years ago

'{% load url from future %}' is throwing TemplateSyntaxError in Django 1.9.

TemplateSyntaxError: 'url' is not a valid tag or filter in tag library 'future'

pydanny commented 8 years ago

@ShipraShalini As this is a closed pull request, please open a separate issue or submit a new pull request.