search

jazzband / django-mongonaut

Built from scratch to replicate some of the Django admin functionality and add some more, to serve as an introspective interface for Django and Mongo.
MIT License
240 stars 67 forks source link

Removed __unicode__() in mongonaut_tags.py. Added a unit test #80

Closed lchsk closed 8 years ago

lchsk commented 9 years ago

Solution for the problem mentioned in https://github.com/pydanny/django-mongonaut/issues/79 with a unit test

lchsk commented 9 years ago

I've used first_name so it would make more sense to put non-ascii characters there. But I can change it back to email. I'll send a pull request afterwards.

garrypolley commented 9 years ago

@lchsk No big deal. I just noticed that was the example application. No need to change it.

garrypolley commented 9 years ago

I'm cool with these changes. :+1: I'll give some others a day or so to look these over and then I'll merge it in.

Thanks for the pull request.

pydanny commented 9 years ago

I think stronger support of unicode is always a good thing. I agree with @garrypolley that we shouldn't switch from email.

garrypolley commented 8 years ago

@lchsk Are you currently using what is in this pull request? It's not had much activity for months.

If you need it I can hit the merge button, but I'd like to see the email used as mentioned above.

lchsk commented 8 years ago

Hi I totally forgot about this (I'm embarrassed enough :(). But yes, I use version from the pull request. I removed unnecessary changes I had made previously. I would be great if you could merge it. Cheers

garrypolley commented 8 years ago

Never feel embarrassed, thanks for the contribution! We appreciate any help we can get on open source projects.