search

jazzband / django-newsletter

An email newsletter application for the Django web application framework, including an extended admin interface, web (un)subscription, dynamic e-mail templates, an archive and HTML email support.
GNU Affero General Public License v3.0
849 stars 205 forks source link

Updated to Py3 code style, removed Six and mock dependencies #351

Closed smithdc1 closed 3 years ago

smithdc1 commented 3 years ago

Python 3.5 is failing. What's the view on keeping 3.5 support for this package given it has reached end-of-life?

frennkie commented 3 years ago

In general I like that we are cleaning up here. But regarding Python3.5 I am a bit reluctant to remove the compatibility now.

Both Ubuntu 16.04 and Debian 9 default to Py35 and are still fully supported. I would suggest to hold off for a few more month.

@dokterbob What is your view on this?

smithdc1 commented 3 years ago

I've currently skipped the failing test on 3.5. This is due to assert_called_once() being added in Python3.6. Not sure if adding back the Mock dependency in its entirety is worth it for this one test?

frennkie commented 3 years ago

Not sure if adding back the Mock dependency in its entirety is worth it for this one test?

I would say: No - not worth it.

Otherwise this looks good to me.