jazzband / django-newsletter

An email newsletter application for the Django web application framework, including an extended admin interface, web (un)subscription, dynamic e-mail templates, an archive and HTML email support.

GNU Affero General Public License v3.0

846 stars 204 forks source link

Migrate to GitHub Actions. #358

Closed jezdez closed 3 years ago

jezdez commented 3 years ago

Travis CI has a new pricing model which places limits on open source.

Many projects are moving to GitHub Actions instead, including Jazzband projects:

This is based on https://github.com/jazzband/contextlib2/pull/26.

It drops support for Python 3.5 because GitHub Actions doesn't fully support them. It's EOL anyway.

Python 3.9 support is also added.

This also relates to #343 in that it enables the release workflow mentioned there with @dokterbob as proejct lead. The version is deducted from the last git tag automatically using setuptools_scm.

TODO:

[x] @jezdez to add JAZZBAND_RELEASE_KEY to the repo secrets.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@51be647). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #358   +/-   ##
=========================================
  Coverage          ?   86.02%           
=========================================
  Files             ?       16           
  Lines             ?     1302           
  Branches          ?      137           
=========================================
  Hits              ?     1120           
  Misses            ?      135           
  Partials          ?       47

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51be647...15adbe3. Read the comment docs.

jezdez commented 3 years ago

@claudep Hey, I've added you as well since you've done some work on this library and I want to make sure we move this along. This is fully in line what all the other Jazzband projects have done FWIW.

claudep commented 3 years ago

Sorry, I'm no longer active on django-newsletter.

jezdez commented 3 years ago

Sorry, I'm no longer active on django-newsletter.

Got it, thank you!

jezdez commented 3 years ago

@aleksihakli Apologies for pulling you into this, I want to move ahead with this pull request and your review would be much appreciated!

aleksihakli commented 3 years ago

Hey @jezdez! I've been a bit busy but I'll review this today. Feel free to ping me via mail or on GitHub in case you need any help, I'll happily assist if I have the bandwidth :)

jezdez commented 3 years ago

Hey @jezdez! I've been a bit busy but I'll review this today. Feel free to ping me via mail or on GitHub in case you need any help, I'll happily assist if I have the bandwidth :)

Understood and no problem, thank you for getting back to me :)