search

jazzband / django-newsletter

An email newsletter application for the Django web application framework, including an extended admin interface, web (un)subscription, dynamic e-mail templates, an archive and HTML email support.
GNU Affero General Public License v3.0
846 stars 204 forks source link

Adds VALIDATE_USER setting config, if False then don't check email in User model #370

Open symbolic09 opened 3 years ago

symbolic09 commented 3 years ago

Need this functionality for the applications that don't have a web-based interface for normal users. if NEWSLETTER_VALIDATE_USER is false in settings.py then it will not check for email in the User model. fixes #369

codecov[bot] commented 3 years ago

Codecov Report

Merging #370 (b9222ff) into master (c350966) will decrease coverage by 0.13%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   86.02%   85.88%   -0.14%     
==========================================
  Files          16       16              
  Lines        1302     1311       +9     
  Branches      137      139       +2     
==========================================
+ Hits         1120     1126       +6     
- Misses        135      136       +1     
- Partials       47       49       +2
Impacted Files Coverage Δ
newsletter/settings.py 90.00% <71.42%> (-2.46%) :arrow_down:
newsletter/validators.py 88.88% <80.00%> (-11.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c350966...b9222ff. Read the comment docs.

ekerstein commented 2 years ago

Any update on this PR? I would greatly like to use this feature.

My newsletter signup is only public-facing. So I want to require emails to always be inputted and disable the validation to not leak user data per this issue: https://github.com/jazzband/django-newsletter/issues/183

newearthmartin commented 7 months ago

I need this PR too as I also do not use the django user system.