jazzband / django-oauth-toolkit

OAuth2 goodies for the Djangonauts!
https://django-oauth-toolkit.readthedocs.io
Other
3.06k stars 777 forks source link

Adds the ability to define how to store a user #1328

Closed 1vank1n closed 1 month ago

1vank1n commented 9 months ago

Description of the Change

Faced a problem that it is not possible now to specify the user's storage location in the validator. This functionality is now a separate public method that can be easily reused. If you agree with me, I will implement the rest of the checklist items (tests, docs, etc.).

Checklist

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.44%. Comparing base (560f84d) to head (c326d04). Report is 9 commits behind head on master.

:exclamation: Current head c326d04 differs from pull request most recent head a0ba9d7. Consider uploading reports for the commit a0ba9d7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1328 +/- ## ========================================== - Coverage 97.56% 97.44% -0.12% ========================================== Files 32 32 Lines 2132 2076 -56 ========================================== - Hits 2080 2023 -57 - Misses 52 53 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

n2ygk commented 1 month ago

@1vank1n sorry for the delay in looking at this. It seems like a reasonable thing to have. Please rebase and do the checklist stuff:

1vank1n commented 1 month ago

@1vank1n sorry for the delay in looking at this. It seems like a reasonable thing to have. Please rebase and do the checklist stuff:

  • [ ] unit-test added
  • [ ] documentation updated
  • [ ] CHANGELOG.md updated (only for user relevant changes)
  • [ ] author name in AUTHORS

I've added it. If it needs anything, please let me know