jazzband / django-oauth-toolkit

OAuth2 goodies for the Djangonauts!
https://django-oauth-toolkit.readthedocs.io
Other
3.06k stars 777 forks source link

OAuth Toolkit Alexa Comaptibility #1397

Closed RitchiS99 closed 1 month ago

RitchiS99 commented 4 months ago

Make it possible to Use Django-O-Auth-Toolkit with Alexa Account Linking

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.28%. Comparing base (9e66f39) to head (813a5e0).

:exclamation: Current head 813a5e0 differs from pull request most recent head 3e1368b. Consider uploading reports for the commit 3e1368b to get more accurate results

Files Patch % Lines
oauth2_provider/views/base.py 33.33% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1397 +/- ## ========================================== - Coverage 97.56% 97.28% -0.28% ========================================== Files 32 32 Lines 2132 2140 +8 ========================================== + Hits 2080 2082 +2 - Misses 52 58 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

n2ygk commented 4 months ago

@RitchiS99 can you provide a reference the the relevant OAuth 2 RFC document that specifies a authorize_json endpoint?

We should not be adding non-standard extensions to this library; you can always extend the class yourself if you need a non-standard feature.

RitchiS99 commented 4 months ago

@RitchiS99 can you provide a reference the the relevant OAuth 2 RFC document that specifies a authorize_json endpoint?

We should not be adding non-standard extensions to this library; you can always extend the class yourself if you need a non-standard feature.

Hi, my commit is because alexa is needing such an endpoint. I am not sure if there is an "offical" endpoint for this, but i would highly recommend adding this, because a communication with alexa shall be possible

n2ygk commented 1 month ago

Closing this because it doesn't appear to be documented as part of the OAuth 2 RFCs/OIDC docs.

Also none of the PR checklist items were provided.

If you want to flesh this out some more to answer the questions around documentation, etc. please reopen it.