search

jazzband / django-oauth-toolkit

OAuth2 goodies for the Djangonauts!
https://django-oauth-toolkit.readthedocs.io
Other
3.13k stars 792 forks source link

`OAuth2Authentication` without DRF's `BaseAuthentication` inheritance #1403

Open Zerotask opened 7 months ago

Zerotask commented 7 months ago

Is your feature request related to a problem? Please describe. We are switching our REST API from DRF to ninja which worked pretty smoothly. Now we want to remove DRF completely. Since we're using OAuth2Authentication we're getting an error because this inherits from a DRF class (from rest_framework.authentication import BaseAuthentication)

Describe the solution you'd like either remove the inheritance (which just consists of 2 empty methods) or add a new neutral OAuth2Authentication class.

Describe alternatives you've considered either we stay with the DRF dependency or we build our own OAuth2Authentication which doesn't inherit from DRF (preferred solution).

Since django-ninja is getting more ground lately, this is surely interesting for others as well.

Additional context https://django-ninja.dev/guides/authentication/#http-bearer

hartungstenio commented 5 months ago

I'm not familiar with Django Ninja, but couldn't you use the Authentication Backend (OAuth2Backend) directly, instead of using the DRF integration?