search

jazzband / django-polymorphic

Improved Django model inheritance with automatic downcasting
https://django-polymorphic.readthedocs.io
Other
1.64k stars 280 forks source link

Auto-discover child models and inlines #582

Open piranna opened 7 months ago

piranna commented 7 months ago

Allow by default to inspect for Model and Inline subclasses to populate the admin forms. Also raise a proper exception in case there are no child models defined.

Fixes #576.

j-antunes commented 7 months ago

Could you also add a unit test?

piranna commented 7 months ago

Could you also add a unit test?

Where could I add them? polymorphic/tests folder?

j-antunes commented 7 months ago

@piranna - That's a good place!

piranna commented 1 month ago

Sorry for keep this open so much time, I have been focused on other parts of our project, but I think we are ready to get this PR merged. What else is needed to do?

piranna commented 1 month ago

Fixed concerns and linting, only missing one are tests, but I don't see how to run them. Anyway, we have already this PR running on production on our systems.