jazzband / django-polymorphic

Improved Django model inheritance with automatic downcasting
https://django-polymorphic.readthedocs.io
Other
1.61k stars 275 forks source link

Support for Django 4.x #598

Open dshunfen opened 2 months ago

dshunfen commented 2 months ago

We're currently on the 3.1.0 stable version of django-polymorphic, which only explicitly states supporting Django 4.0. Is it safe to say this is true for all Django 4.x?

bckohan commented 2 months ago

The tests run on Django 4-5

py312-django40: OK (37.11=setup[19.24]+cmd[17.87] seconds) py312-django41: OK (28.26=setup[11.27]+cmd[16.99] seconds) py312-django42: OK (28.32=setup[11.27]+cmd[17.06] seconds) py312-django50: OK (30.74=setup[11.39]+cmd[19.35] seconds)

So I think so yes. I'm using it in production on systems running Django 4.2 and 5.0

Seems like the whl classifiers and docs could be updated.

leveille commented 2 months ago

Hey there. The pre release version (4.0a) tests up through Django 5. Version 3.1.0 (the most recent version available on pypi) does not test against 4.2/5 (unless it does and we just missed it). We just would like to know if others use 3.1 on Django 4.2 and if it's generally considered safe. So to be clear, you are using 3.1 on both Django 4.2 and 5 prod systems without issue? Thank you for your insight.

bckohan commented 2 months ago

Hey there. The pre release version (4.0a) tests up through Django 5. Version 3.1.0 (the most recent version available on pypi) does not test against 4.2/5 (unless it does and we just missed it). We just would like to know if others use 3.1 on Django 4.2 and if it's generally considered safe. So to be clear, you are using 3.1 on both Django 4.2 and 5 prod systems without issue? Thank you for your insight.

I am. Multiple production systems, different products running 3.1 on Django 4.2/5.0. No issues. Django 3.2 support is sunsetting now so it'd be a great time to release a version tested against supported Python/django versions.

j-antunes commented 2 months ago

I was the one that created a pre release version 4.0a. I'm using it with django 4.1.13 and python 3.11. No issues. I have been using it for a while now. I would suggest for you try that version. Sorry that it's not updated with pip, but I don't have and have not been able to get access to be able to push to pip.

du-song commented 2 months ago

Any plan to release 4.0 ?

j-antunes commented 2 months ago

Unfortunately that is out of my control. I requested access to pypi to be able to push a new version. Still waiting on access to it.

in the meantime there is an unofficial version 4.0.0a in the git releases, feel free to use that one.

On Fri, May 3, 2024 at 9:01 AM du-song @.***> wrote:

Any plan to release 4.0 ?

— Reply to this email directly, view it on GitHub https://github.com/jazzband/django-polymorphic/issues/598#issuecomment-2093197360, or unsubscribe https://github.com/notifications/unsubscribe-auth/APIRGLXWL4OKEO2ZNRQUFIDZAORDJAVCNFSM6AAAAABGKBJRWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGE4TOMZWGA . You are receiving this because you commented.Message ID: @.***>

akx commented 1 month ago

@j-antunes Any news on the PyPI front?

@vdboor I see you're still a maintainer of the package on PyPI, anything you could do to nudge this along? Cheers :)

j-antunes commented 1 month ago

@akx - unfortunately no update :(

nattyg93 commented 1 month ago

@j-antunes I couldn't find any transfer requests for django-polymorphic in https://github.com/pypi/support/issues. Have you made a PyPI transfer request?

It sounds like you've satisfied the prerequisites of contacting the original owner (vdboor - who is understandably busy with parenting), and there is the evidence in #548 that the original owner transferred the project to Jazzband.

You can open a transfer request here: https://github.com/pypi/support/issues/new?assignees=&labels=PEP+541&projects=&template=pep541-request.yml&title=PEP+541+Request%3A+PROJECT_NAME

j-antunes commented 1 month ago

@nattyg93 - I was not aware of that. I submitted the request: https://github.com/pypi/support/issues/4164

What I did was ask for help on element: https://app.element.io/#/room/#jazzband:matrix.org but no one very got back to me.