search

jazzband / django-push-notifications

Send push notifications to mobile devices through GCM or APNS in Django.
MIT License
2.26k stars 613 forks source link

Support for django3 #550

Closed mousetail closed 4 years ago

mousetail commented 4 years ago

Currently, this module uses legacy APIs like six and python2_unicode_compatible. These have been deprecated for a long time and now have been removed removed from django3.0 onward. python2_unicode_compatible has no effect in python3, and can be safely removed. six.string_types can be safely replaced by str.

shree-ranga commented 4 years ago

I had to replace all the "django.utils.six" to just "import six"

elcolie commented 4 years ago

I am using Django3 from master branch with commit c610dd9c7871f4e81bdffce783df8b040ca22878 Here is the requirements.txt Assume you willing to run master -e git+git@github.com:jazzband/django-push-notifications.git@master#egg=django-push-notifications

-e git+git@github.com:jazzband/django-push-notifications.git@c610dd9c7871f4e81bdffce783df8b040ca22878#egg=django-push-notifications

iamareebjamal commented 4 years ago

You shouldn't use master branch, use a specific commit

iamareebjamal commented 4 years ago

@jleclanche Can we please get the latest version released on PyPI?

jleclanche commented 4 years ago

This is part of jazzband, I don't think I'm the only one able to make a release. I'm currently busy with other matters but don't let anything be blocked on me.

jamaalscarlett commented 4 years ago

I can look into it today. What is the commit hash for the version?

iamareebjamal commented 4 years ago

@jamaalscarlett Latest on master which is more than a month old https://github.com/jazzband/django-push-notifications/commit/c610dd9c7871f4e81bdffce783df8b040ca22878

jamaalscarlett commented 4 years ago

@jleclanche can you add the pypi api token as a secret. I am not able to see the Settings tab. Once that is done, I can set up the github workflow and deploy the new version.

jleclanche commented 4 years ago

I don't have access to the settings tab either.

jleclanche commented 4 years ago

@jamaalscarlett I can add you as another owner on pypi though, what's your username there?

jamaalscarlett commented 4 years ago

@jleclanche my username is: jamaalscarlett

jleclanche commented 4 years ago

@jamaalscarlett you need a verified primary email address to be added as owner.

jamaalscarlett commented 4 years ago

@jleclanche OK, email address has been verified.

jleclanche commented 4 years ago

Done. Let me know if you need anything else.

jheld commented 4 years ago

Do we have any updates here? Our project is also needing this in. We'd be more than happy to help test it, too.

jamaalscarlett commented 4 years ago

https://github.com/jazzband/django-push-notifications/releases/tag/2.0.0 https://pypi.org/manage/project/django-push-notifications/release/2.0.0/

I still need to fix the release notes, but it is available to download.