search

jazzband / django-push-notifications

Send push notifications to mobile devices through GCM or APNS in Django.
MIT License
2.26k stars 613 forks source link

Edit old migrations to use new USER_MODEL setting value #572

Open ezheidtmann opened 4 years ago

ezheidtmann commented 4 years ago

The USER_MODEL setting appears very useful, but in the 2.0.0 release, the original tables are created with user as a ForeignKey to settings.AUTH_USER_MODEL.

This creates several problems, including that ./manage.py makemigrations will create a migration in push_notifications that can't be committed or deployed if the project was installed from pypi.

This PR edits old migrations to use USER_MODEL directly. For new users, this seems to honor the intention of the feature. For existing users, they should expect trouble if they ever change the USER_MODEL or AUTH_USER_MODEL settings, with or without this patch.

ezheidtmann commented 2 years ago

Rebased on the latest release 3.0.0

joeyorlando commented 1 year ago

bump