Closed frallain closed 2 years ago
Would be really nice to have a new release because the current released version does not supports Django 4.0. it raise the following error.
File "push_notifications/admin.py", line 3, in <module>
from django.utils.encoding import force_text
ImportError: cannot import name 'force_text' from 'django.utils.encoding'
Just to add - it also doesn't work with current versions of PyJWT, which make life very difficult when using other packages rely on the new PyJWT API.
Ditto, code needs updated for compatibility with Django 4.0. The following conflicting lines:
from django.utils.encoding import force_text
from django.utils.translation import ugettext_lazy as _
should be updated to:
from django.utils.encoding import force_str
from django.utils.translation import gettext_lazy as _
The required fixes seem to already be present: https://github.com/jazzband/django-push-notifications/commit/ff1337798ce00a059edeccb9702c1c6db61a6bf8
we just need a new release created
The force_text
was replaced with force_str
in ce2140fccecb83cb2bf4203424bbdd47f44428ea.
Thank you @bigfootjon and @sevdog, I concur. We are awaiting a release. Any known issues holding it up?
@simonkern Would it be possible to create a new release?
I only opened two or three pull requests, but have no permissions regarding this package.
@simonkern Thanks for the fast response. Do you know who has? It is a really nice package, and it would be a pity to lose it due to the lack of new releases.
Sorry everyone, I have pypi access
Which commit are we using for the release?
Latest commit from ‘master’ seems fine to me. It has some missing migrations in it. 4.0 support landed a few commits before that
OK I'll use db0606c908b669d9803cdfc26fca0926cb059fd3
It will be 2.1.0
Thanks for getting this out, but if it's not too late, the version number should probably be 3.0.0 since it's dropping support for Django 1.x: https://github.com/jazzband/django-push-notifications/commit/da97ebe8f892a28c9288982ce19713226a6e5d4b#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R30
any updates please ?
@jleclanche could you create this release. Apparently when I restored my phone, it reset my authenticator app so I am currently locked out of pypi
@jamaalscarlett I don't feel comfortable doing the release myself, but I can approve anyone who's stepping up to do it. This is a jazzband project after all.
@jleclanche and @jamaalscarlett Is there something in particular about not feeling comfortable with a new release? Not clear what the hold up is.
@bradleydworak I don't feel comfortable doing a release on this project because I haven't done one in years and I don't use the library anymore to test it / know if it's ready for a release.
@jleclanche I am using the latest master for a while, and its sending push-notifications to IOS and Android.
The current version 2.0.0 does not support Django 4.0 which is a blocker for many people. and a new release would unblock it.
Again: If another jazzband member wants to step up to do the release, I can give permissions. @jamaalscarlett I can also add whatever account of yours you need. But I am not comfortable doing it myself.
Could the version be bumped to 3.0 and it released? That would be lower risk since people shouldn't be hit with the package upgrading under them and then more testing can happen for those that are ready to make the upgrade.
My pypi account was finally unlocked, so I can create the release 3.0.0 using commit 6fde7302d7e85008b600a56b394a9f8841970e55 tomorrow, unless there are any objections
Would it be possible to enjoy a new release of django-push-notifications ? It has been one year and half since no release and I can see several commits the community could benefit from, given that Django 4.0 is out and that the current 2.0.0 release emits the following warnings :
Thanks for this package, keep up the good work!