jazzband / django-push-notifications

Send push notifications to mobile devices through GCM or APNS in Django.
MIT License
2.26k stars 613 forks source link

feat: Add python3.10 support (ugly workaround) #648

Closed bertonha closed 1 year ago

bertonha commented 2 years ago

the sub dependency of apns2 hyper is completely abandoned and it does not support python 3.10 simple because it uses some packages from collections where on python 3.10 it moved to collections.abc

I think the clean way to properly fix it, would be to move to a more maintained package to do Apple Push Notifications. which might be aioapns

codecov[bot] commented 2 years ago

Codecov Report

Merging #648 (7cb6936) into master (db0606c) will increase coverage by 0.07%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
+ Coverage   68.43%   68.51%   +0.07%     
==========================================
  Files          26       26              
  Lines        1112     1121       +9     
  Branches      243      244       +1     
==========================================
+ Hits          761      768       +7     
- Misses        313      315       +2     
  Partials       38       38              
Impacted Files Coverage Δ
push_notifications/__init__.py 85.71% <77.77%> (-14.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db0606c...7cb6936. Read the comment docs.

Andrew-Chen-Wang commented 2 years ago

apns2 is a pain since no one maintains this valuable package. We should get everyone to use a fork instead. aioapns is for asyncio.

We can name the fork apns2-py and set it up in Jazzband for maintenance.