jazzband / django-push-notifications

Send push notifications to mobile devices through GCM or APNS in Django.
MIT License
2.24k stars 605 forks source link

Update topic send_message docs in README #660

Closed alenzeinolov closed 2 years ago

alenzeinolov commented 2 years ago

send_message for GCM/FCM topics now requires cloud_type argument to be provided, but it is not shown in the docs, therefore copying the snippet will not work straight away.

I had to lookup function definition, hope this will save some time for other people :)

codecov[bot] commented 2 years ago

Codecov Report

Merging #660 (25a30a1) into master (758b26f) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   68.49%   68.46%   -0.03%     
==========================================
  Files          26       26              
  Lines        1111     1110       -1     
  Branches      243      243              
==========================================
- Hits          761      760       -1     
  Misses        312      312              
  Partials       38       38              
Impacted Files Coverage Δ
push_notifications/models.py 77.86% <0.00%> (-0.18%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 758b26f...25a30a1. Read the comment docs.