jazzband / django-push-notifications

Send push notifications to mobile devices through GCM or APNS in Django.
MIT License
2.26k stars 613 forks source link

running migration problem #662

Open ahmedelfateh opened 2 years ago

ahmedelfateh commented 2 years ago

after setting up django_push_notification and adding push_notification to the app, I run the migration and this msg appere

Your models in app(s): 'push_notifications' have changes that are not yet reflected in a migration, and so won't be applied.
  Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.

and when run makemigrations, this appere

 Migrations for 'push_notifications':
  /usr/local/lib/python3.8/site-packages/push_notifications/migrations/0010_auto_20220629_1231.py
    - Alter field id on apnsdevice
    - Alter field id on gcmdevice
    - Alter field id on webpushdevice
    - Alter field id on wnsdevice

I am using the django~=3.2 / django-push-notifications==3.0.0 with python:3.8.12

what is the problem here?

jamaalscarlett commented 2 years ago

@ahmedelfateh This is happening because of https://docs.djangoproject.com/en/3.2/ref/settings/#default-auto-field. If you started your project on Django 3.2 or newer, your settings.py file contains

DEFAULT_AUTO_FIELD = 'django.db.models.BigAutoField'

but django push notifications uses AutoField. The fix would be to change the setting to:

DEFAULT_AUTO_FIELD = 'django.db.models.AutoField'

or except the new migration.

denizdogan commented 1 year ago

@jamaalscarlett Is there any reason why this migration can't just be included in the library at this point? Django 2 is not supported any longer, 3.2 is the oldest supported version, and it's LTS until April 2024.

PureTryOut commented 1 year ago

I too would prefer if the library just included the migration. I have no interest in a Django version lower than 3.2 and now every time I run makemigrations this migration comes up I have to remove (as it's not in my version control and thus not persistent).

jamaalscarlett commented 1 year ago

@PureTryOut I will take a look at this tonight

Aidar commented 3 months ago

Any updates?

CoderMungan commented 2 months ago

any update?