jazzband / django-push-notifications

Send push notifications to mobile devices through GCM or APNS in Django.
MIT License
2.23k stars 605 forks source link

support interruption level on ios devices #711

Open 50-Course opened 3 months ago

50-Course commented 3 months ago

Hello team,

Digging deep into PyAPNs2, I found that the library does have internal priority levels, distinctively, Immediate and Delayed.

In addition to this, support different notification types, such as Background, Alert, VoIP, Complication, FileProvider and mdm.

This patch extend one or two of these interfaces to support interruption_levels on User Notification Center. Below is what is contained in this commit:

This patch is a work-in-progress and I would like to get feedback on this before I proceed with the next steps. Can you take a look at this? @pomali

CC: @jleclanche

Commits:

jleclanche commented 3 months ago

Your PR is difficult to review because of whitespace changes. If there are whitespace fixes to make, please do them in a separate commit/PR.

50-Course commented 3 months ago

That was my editor overriding the editorconfig settings, I think I would have to find a way make it respect editorconfig. It runs black immediately before push, this have been a recent development for me, due to internal changes in my config.

With that pointed out, i'd try see to revert to previous change.