Changed firebase-admin's deprecated send_all method for send_each

jazzband / django-push-notifications

Send push notifications to mobile devices through GCM or APNS in Django.

MIT License

2.26k stars 613 forks source link

Changed firebase-admin's deprecated send_all method for send_each #715

Closed guspix closed 5 months ago

guspix commented 5 months ago

Closes #712. Let me know if I need to do anything else.

guspix commented 5 months ago

I can see that the Python 3.6 tests failed while the rest passed, since newer versions of firebase-admin support Python 3.7 and up. Can we remove support for 3.6, since it has been deprecated for over two years, or is that a deal breaker?

jamaalscarlett commented 5 months ago

@guspix I have a PR dropping python 3.6 support https://github.com/jazzband/django-push-notifications/pull/718

jamaalscarlett commented 5 months ago

@guspix can I get a review on https://github.com/jazzband/django-push-notifications/pull/718