search

jazzband / django-push-notifications

Send push notifications to mobile devices through GCM or APNS in Django.
MIT License
2.26k stars 613 forks source link

Remove python 3.6 support. #718

Closed jamaalscarlett closed 5 months ago

guspix commented 5 months ago

Looks good to me! Only tiny thing I can see is that the test_admin file has an if statement checking if the Python version is >= 3.7 which I guess would now be innecesary, but I don't think it really matters. This is my first time contributing so I'm not sure how this works, should I submit a review approving the code changes?

jamaalscarlett commented 5 months ago

Looks good to me! Only tiny thing I can see is that the test_admin file has an if statement checking if the Python version is >= 3.7 which I guess would now be innecesary, but I don't think it really matters. This is my first time contributing so I'm not sure how this works, should I submit a review approving the code changes?

Yes please, once you approve it. I will merge it. Then you can rebase your pr to fix the failing 3.6 test. Then I will cut a release. Thanks again!

jamaalscarlett commented 5 months ago

@guspix @50-Course

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.39%. Comparing base (9bf5fda) to head (b85b162). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #718 +/- ## ========================================== + Coverage 70.28% 70.39% +0.10% ========================================== Files 26 27 +1 Lines 1097 1101 +4 Branches 249 180 -69 ========================================== + Hits 771 775 +4 Misses 288 288 Partials 38 38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.