search

jazzband / django-push-notifications

Send push notifications to mobile devices through GCM or APNS in Django.
MIT License
2.23k stars 605 forks source link

Migrate from apns2 to aioapns #721

Open macro1 opened 2 months ago

macro1 commented 2 months ago

Disclaimer: I haven't tested this with real interactions with APNs.

The goal is to remove the indirect use of hyper (which is no longer maintained) and unblock compatibility with newer Python versions without breaking too many of the existing contracts.

I did remove the 'creds' parameter that existed in many of the functions. The value that would have been accepted is a part of apns2, so it cannot be realistically supported.

Somewhat surprising.. It seems the indentation is currently set to tabs? This PR currently converts several of the files, which may not be the right approach.

macro1 commented 2 months ago

I closed this when I saw #696, but I'm re-opening it because the approaches are very different. This PR does a full replacement rather than adding an alternate APNS implementation.

50-Course commented 1 month ago

i'd be following this development closely, and might have to re-base (#711) on this. Let me know if you need some help or require unblocking at some point.