search

jazzband / django-queued-storage

Provides a proxy for Django storage backends that allows you to upload files locally and eventually serve them remotely
http://django-queued-storage.rtfd.org/
BSD 3-Clause "New" or "Revised" License
318 stars 62 forks source link

django 1.10 support #22

Closed thijstriemstra closed 7 years ago

thijstriemstra commented 8 years ago

django 1.10a1 was released and this PR aims to make it compatible.

ashwoods commented 7 years ago

Please don't commit directly into master, and I wasn't done reviewing the commits. No need to worry though, it's not the end of the world ;) Could you revert the commit and leave it as before. Create a new PR, and go through the comments I left on the commit?

onekiloparsec commented 7 years ago

Ok thanks. Which commit you want me to revert? Just the last one (about parameter max_length)? Or the whole merge? (no problem for that).

ashwoods commented 7 years ago

Whole merge.

onekiloparsec commented 7 years ago

Hard reset + force push ok for you? Or just revert?

ashwoods commented 7 years ago

revert is neater.

onekiloparsec commented 7 years ago

Done.

onekiloparsec commented 7 years ago

Hi. I've been busy these days, and I am about to leave for vacations. Anything you want me to make before leaving? Everything I've done is pushed to django-110 branch. But I couldn't make a PR with it, since I pushed right into the project, not my fork. If you prefer, I can remove the helper Storage classes, this would solve the sys.stdout.write thing.