search

jazzband / django-redis

Full featured redis cache backend for Django.
Other
2.88k stars 430 forks source link

Adapting redis-py tox strategy #574

Open WisdomPill opened 2 years ago

WisdomPill commented 2 years ago

@terencehonles regarding tests, lately I have been contributing a little to redis-py and I saw how they are using tox with docker for setting up the environment. I find it very clean and elegant since you just need docker running and the test suite will take care of the rest.

Would you mind taking a look and get back to me? I would like to have something similar in the future for django-redis as well.

Have a look here

terencehonles commented 2 years ago

Thanks for the link, I'll try to look at this sometime soon, but a little busy at the moment. Thanks for handling the release :slightly_smiling_face:

WisdomPill commented 2 years ago

I would also add testing for the last supported versions of redis, which are described here.

I do not like the idea of increasing the testing matrix so much, so I guess now only 6.2 and 5.0 should be enough since they are the only ones who are going to get the security patches.

Last but not least I would test for redis-py 3 and redis-py 4, so a little bit of adaptation od documentation and tox is needed, I will try to have a look at least on using tox-docker this weekend