jazzband / django-redshift-backend

Redshift database backend for Django
Apache License 2.0
83 stars 47 forks source link

Redshift support time zones in time stamps from Sep, 2016 #23

Closed Surgo closed 7 years ago

Surgo commented 7 years ago

See: Amazon Redshift introduces new data type to support time zones in time stamps

So,

dkarchmer commented 7 years ago

Is there a migration path to convert an existing database?

Surgo commented 7 years ago

Maybe no way to migrate using django's migration mechanism. I migrated manually.

emyller commented 7 years ago

Yo @shimizukawa -- can we proceed merging this one? It is highly demanded feature. Thank you. :)

shimizukawa commented 7 years ago

Actually I have no spare time but I'll take a look ASAP.

emyller commented 7 years ago

Hey @Surgo, can you please update the README file at the "Type mapping" section to match the underlying Redshift type? Thanks!

Surgo commented 7 years ago

@emyller Thank you for your comment. updated :)

shimizukawa commented 7 years ago

From now, I check this PR.

shimizukawa commented 7 years ago

I'll merge this PR after resolve conflict. @Surgo can you please rebase?

Surgo commented 7 years ago

@shimizukawa rebased :)

shimizukawa commented 7 years ago

Thanks, I'll merge soon!

On Sun, Aug 27, 2017 at 7:21 PM Kosei Kitahara notifications@github.com wrote:

@shimizukawa https://github.com/shimizukawa rebased :)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/shimizukawa/django-redshift-backend/pull/23#issuecomment-325189694, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJQR1W6I8v1_iJxtvJOSu6orC6-ANFcks5scUMrgaJpZM4OcU_H .

shimizukawa commented 7 years ago

@Surgo please check this updated README if you have a chance ;) https://github.com/shimizukawa/django-redshift-backend/commit/47d92feb586c1c19a346b18e6666f9ca7c4efd1e#diff-88b99bb28683bd5b7e3a204826ead112

Surgo commented 7 years ago

@shimizukawa thank you for your support!