Codecov Report

Merging #74 (081d90d) into master (f977603) will increase coverage by 1.39%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   43.64%   45.04%   +1.39%     
==========================================
  Files           2        3       +1     
  Lines         236      242       +6     
  Branches       62       62              
==========================================
+ Hits          103      109       +6     
  Misses        123      123              
  Partials       10       10

Impacted Files	Coverage Δ
django_redshift_backend/base.py	`42.91% <100.00%> (+0.24%)`	:arrow_up:
django_redshift_backend/__init__.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f977603...081d90d. Read the comment docs.

michaelwheeler commented 3 years ago

Failing tests appear to simply be due to incompatible Django/Python combinations. Let me know if there's anything else I can do to get this merged!

shimizukawa commented 3 years ago

Thanks, 2 failing checks are caused from django-dev dropping python-3.6 and 3.7 support https://github.com/django/django/blob/64a0d1ef6e7a6739148996e9584bbb61fe3dcc60/setup.cfg#L35

No actions are required. I'll take a look later.

shimizukawa commented 3 years ago

Memo: Django provides supports_aggregate_filter_clause feature from django-2.0. PR: https://github.com/django/django/pull/8352

jazzband / django-redshift-backend

Specify FILTER WHERE syntax not supported #74

Feature or Bugfix

Purpose

Detail

Relates

Codecov Report