search

jazzband / django-rest-knox

Authentication Module for django rest auth
MIT License
1.18k stars 213 forks source link

Make AuthToken model pluggable [WIP] #184

Closed kalekseev closed 6 months ago

kalekseev commented 5 years ago

Partially fixes https://github.com/James1345/django-rest-knox/issues/159.

This is a proof of concept that the feature is not that complex and can be added with minimal breaking changes. Would like to receive comments on that before investing more time.

johnraz commented 5 years ago

Hi! Thanks a lot for this. The history seems to be a bit messed up. Could you rebase and make sure only your commits appear. I’ll try to follow up with a review ASAP once that’s done.

kalekseev commented 5 years ago

@johnraz done

kalekseev commented 5 years ago

it seems that develop branch doesn't contain all the master commits so pr includes a couple of comments from master

johnraz commented 5 years ago

You should base your work on develop, not master.

ghost commented 4 years ago

Hey - any news on this? I need to add a field to tokens, and if this will be merged soon, I'll wait for it :)

kalekseev commented 4 years ago

@alex-yobota sorry but my original plan is different from what maintainers want:

Yes sure but still I was challenging the fact that we could make this even more flexible in the case someone needs it. If the point is to make the model pluggable, I would probably go for something fully pluggable unless it's proven too complex.

It's quite reasonable decision to make it fully customizable but I don't have resources to do that now. If I will have new projects with similar requirements in near future I will implement this.

ghost commented 4 years ago

@alex-yobota sorry but my original plan is different from what maintainers want:

Yes sure but still I was challenging the fact that we could make this even more flexible in the case someone needs it. If the point is to make the model pluggable, I would probably go for something fully pluggable unless it's proven too complex.

It's quite reasonable decision to make it fully customizable but I don't have resources to do that now. If I will have new projects with similar requirements in near future I will implement this.

Cool, thanks for trying anyway :)

johnraz commented 6 months ago

As this PR is quite old and it was decided to make this more pluggable I'm going to close for now.