search

jazzband / django-rest-knox

Authentication Module for django rest auth
MIT License
1.18k stars 213 forks source link

Remove cryptography dependency? #199

Closed tasn closed 4 months ago

tasn commented 4 years ago

sha512 is already in hashlib so the cryptography dependency is not really needed. This is especially important since the cryptography dep can be a hassle to setup in some cases (requires a compiler, headers and openssl, as per django-rest-knox docs).

It's a very easy change to make and won't break existing applications as long as they haven't manually set the hash setting and override it to something from cryptography. If they have: this can be a breaking change for a future version.

Rotzbua commented 4 years ago

I agree. Seems it was already modernized in #173, but modern python3 does not require this dependency anymore. I created a pr.

johnraz commented 4 months ago

this has been implemented and released