Open brycekellogg opened 4 years ago
I agree this is a valid option but introducing a new settings means new documentation, more complexity in the code base and more tests. As this is a small project with very limited resources I think we should keep it as is.
Currently the
LoginView
,LogoutView
, andLogoutAllView
all have hardcodedpermission_classes
toIsAuthenticated
. While this is definitely the minimum needed as discussed in issues #64 and #9, sometimes additional permissions are required. For our use case, we are using API keys and only want a user to be able to login/out/etc if they have an API key. Currently we solve this like so:One possible solution could be similar to how Djoser does it:
where we set the permissions in settings.py like so: