search

jazzband / django-rest-knox

Authentication Module for django rest auth
MIT License
1.15k stars 211 forks source link

chore(migration): use f-string #317

Closed Rotzbua closed 8 months ago

Rotzbua commented 12 months ago

Just some migrations to modern python.

codecov[bot] commented 12 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dd7b062) 91.70% compared to head (af386f9) 91.70%.

Files Patch % Lines
knox/models.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #317 +/- ## ======================================== Coverage 91.70% 91.70% ======================================== Files 9 9 Lines 229 229 Branches 35 35 ======================================== Hits 210 210 Misses 16 16 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Rotzbua commented 8 months ago

I rebased again, because the github rebase changed more lines of code. I do not know why codecov complains because it is basically the same. Do you know the reason?

giovannicimolin commented 8 months ago

@Rotzbua It's complained because of the changed lines is not covered by any tests. It's ok though.

Thanks for the PR! :grin: