Documentation includes mention of deleted token salting

jazzband / django-rest-knox

Authentication Module for django rest auth

MIT License

1.15k stars 211 forks source link

Documentation includes mention of deleted token salting #323

Closed dgerlanc closed 5 months ago

dgerlanc commented 9 months ago

The documentation includes a setting for SALT_LENGTH even though salting was removed long ago.

Would be great to remove this reference as it suggests that salting of tokens is still used!

I searched the head of the develop branch and could not find a mention of this setting except in the changelog and migrations so I'm not sure why it's showing up in the docs!

See https://jazzband.github.io/django-rest-knox/settings/.

johnraz commented 5 months ago

This most likely comes from the fact that the gh-pages branch is outdated ... https://github.com/jazzband/django-rest-knox/blob/gh-pages/settings/index.html.

I will mention this in https://github.com/jazzband/django-rest-knox/issues/304

giovannicimolin commented 5 months ago

@johnraz @dgerlanc We now have a Ci job that automatically deploys the latest documentation to GH-pages.

https://github.com/jazzband/django-rest-knox/pull/343

johnraz commented 5 months ago

@giovannicimolin wonderful doc is up to date now! Closing this one