Add Django 3.2 support (fixes #126)

jazzband / django-revproxy

Reverse Proxy view that supports all HTTP methods, Diazo transformations and Single Sign-On.

Mozilla Public License 2.0

305 stars 118 forks source link

Add Django 3.2 support (fixes #126) #128

Closed thatsed closed 2 years ago

thatsed commented 3 years ago

Django 3.2 support, fixes #126

Changes discussed in #127

Changelog:

added check for response.headers attribute (new in Django 3.2), fallback to old interface if missing for backward compatibility
updated tests to expect Django 3.2+ response.headers
added Django 3.2 in .travis.yml

I did not bump the version, that's something @seocam or @rougeth might want to look into.

coveralls commented 3 years ago

Coverage remained the same at 100.0% when pulling b9fa8375d03fd68747dcb7273a97c19d788aa51b on Innovativity:master into db7031b521688ed48a35c16742c199fe0ec228b2 on TracyWebTech:master.

b3nav commented 3 years ago

Thanks for the PR - it definitely fixes the issue with Django 3.2 - any plans on getting this in @seocam, @rougeth?

sinwoobang commented 3 years ago

I would like to introduce django-revproxy with this patch, but it seems like it is not released yet.

brianmay commented 3 years ago

Anyone how can help fix the CI, it would be appreciated. I have no idea how to stop github from wanting travis to run.

brianmay commented 3 years ago

Not sure what you mean about "not released yet"

https://pypi.org/project/django-revproxy/

There has not been any releases since it moved to django-revproxy however. I suspect this might require fixing up CI first.

brianmay commented 3 years ago

Can you please rebase against the latest master?

Thanks

sinwoobang commented 3 years ago

@brianmay Thank you for the feedback.

What I meant was that I was not able to use the patched code since it is not merged yet. I am looking forward to being merged this PR since the version of a Django service that I have used is 3.2.

By the way, could I have a question? It seems like there have been some updated things after version 0.10 has been released. However, its release date is Feb 2020 where it looks quite a while ago.

I 'never' mean to bother you but just curious. Are there some reasons that the release is not regular?

brianmay commented 3 years ago

This project needs a maintainer who is able to make regularly releases. That is not me, I don't have the time. I don't even use the project. Hoping that moving this to jazzband might help....

seocam commented 3 years ago

The code looks fine to me but we need to fix the coverage and the problem in codeclimate (which I can't even see what is the problem is because of the repo migration to jazzband).

brianmay commented 3 years ago

These issues have been fixed in master. Hence why I asked you to rebase against the latest master.

vladislavkoz commented 2 years ago

Any updates on this?

brianmay commented 2 years ago

I think this was merged in #137. Closing.