Closed my-umd closed 12 months ago
I think we need to fix the items in https://github.com/jazzband/django-revproxy/issues/129 first. At least as many as possible.
Unfortunately, I simply do not have time to look at this.
@seocam @brianmay Any updates on this one?
This has been fixed in #148!
Hi @JeroenJADS, this fix works great, but to @my-umd's question, it's not yet released on PyPi. This is a problem because the latest django-revproxy (with the fix) can't be used as a dependency in a requirements.txt file for a project published on PyPi. Locally the github url to the master branch can be used, but PyPi will reject that for security reasons.
Hi @JeroenJADS,
Hi @JeroenJADS, this fix works great, but to @my-umd's question, it's not yet released on PyPi. This is a problem because the latest django-revproxy (with the fix) can't be used as a dependency in a requirements.txt file for a project published on PyPi. Locally the github url to the master branch can be used, but PyPi will reject that for security reasons.
any news regarding ^^?
I can confirm that the current master branch works correctly with Django 4.1. So a new release would be nice.
I think a new release could be released as some tasks from #129 have been resolved.
@brianmay Could you please publish a new release? :) Thanks!
Unfortunately I have no time to even look at this package. Is the CHANGELOG.rst
up to date for the next release? If not it would help if somebody provided a PR to update this.
My 1st attempt to release failed. https://github.com/jazzband/django-revproxy/actions/runs/4267415470/jobs/7428996053
Probably something trivial wrong, no idea what.
Thank you for your time. I'll take a look. I think this is happening because of the version declared in the __init__.py
file.
https://github.com/jazzband/django-revproxy/pull/163 may fix the issue :).
@brianmay 0.11.0 tag may be removed and recreated again using HEAD commit of master branch. Thanks in advance.
I see it is still giving 500 error during upload process... :(
I did that, but it didn't work out. Oh, crap that was my fault. Somehow I thought my git repo was up-to-date when it wasn't which led to a sequence of errors on my end.
Yes, still not working. No idea why.
Thank you! I'm looking into this...
@brianmay Is the JAZZBAND_RELEASE_KEY
secret filled?
Not 100% sure, but it doesn't look like it to me.
Once secret it's set you can't see it anymore. You may see it blank but it can be there.
Looks like not set to me. Similar if I click variables.
Ok, thank you! Who could add that secrets? 🤔
I've joined the Jazzband organization and I've assigned to myself as a team member.
I think I can publish releases and manage issues now but my PRs still need at least one approval.
Lets see then if you can publish this release :-)
I'll remove 0.11.0 and 0.11.1 tags and I'll recreate again.
Sounds good. Don't forget to update the CHANGELOG.rst
and revproxy/__init__.py
files also :-)
Oops! On it!
Done!
Approved. I think you should be able to merge it. Once the CI is done.
Yes! :D I've merged it and I've created a new release... Hope it works...
Doesn't look good :-(
It didn't 🥲. I think this is related to that secret.
I've published an issue in jazzband help repository. I'll let you know...!
Can this be closed?
Not yet as 0.11.0 is not available in PyPi. There is an issue in the jazzband/help repository.
@andruten or @brianmay there is a comment on how to fix the release of 0.11.0 on the Jazzband issue, can you try it out?
No, that is not a work around we can implement. It is just asking the user to download djang-revproxy from github instead of PyPi.
Ok, sorry for creating noise, very much appreciate it.
Not sure if there is a better channel to ask this question. I see 0.11.0, which has fix for django 3.2, has not been released. Any plan when to release it? Thanks.