Closed SebCorbin closed 1 year ago
Merging #614 (e88eeac) into master (4934ffe) will increase coverage by
1.61%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #614 +/- ##
==========================================
+ Coverage 84.63% 86.25% +1.61%
==========================================
Files 52 52
Lines 2076 2080 +4
==========================================
+ Hits 1757 1794 +37
+ Misses 319 286 -33
Impacted Files | Coverage Δ | |
---|---|---|
silk/views/requests.py | 98.85% <100.00%> (+6.07%) |
:arrow_up: |
silk/request_filters.py | 83.01% <0.00%> (+17.61%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Two enhancements in this PR:
'show', 'order_by', 'order_dir', 'view_style'
params are retained so when you click on the "Requests" menu item, you keep these (they won't be reset when "Clear all filters" is clicked as they are not filters)I will open a cleanup issue, as I find the filters form heavily relying on JavaScript, and it should not be IMHO.