sgelis commented 1 year ago

Fixes jazzband/django-silk#531.

Tests pass and manual testing shows no regression as far as I can tell.

codecov[bot] commented 1 year ago

Codecov Report

Merging #635 (074001a) into master (deb9b1f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files          52       52           
  Lines        2093     2093           
=======================================
  Hits         1807     1807           
  Misses        286      286

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

albertyw commented 1 year ago

@sgelis Sorry, it looks like I accidentally closed this pull request when I tried rebasing it on top of #639 to get the tests to pass. Since the pull request is closed, I also can't push your changes back to your repository fork.

Your branch still exists at https://github.com/albertyw/django-silk/tree/sgelis-master but you'll need to grab the code on that branch again, push the changes to github, and reopen this pull request. You can do that with

git remote add albertyw git@github.com:albertyw/django-silk
git fetch albertyw
git cherry-pick 97a5d33
git cherry-pick c4cd70a
git push

I also created https://github.com/sgelis/django-silk/pull/1 as another way to get your commits back in your repository.

sgelis commented 1 year ago

@albertyw I merged sgelis#1 but this does not seem to reopen this PR which still seems emptied :confused:

jazzband / django-silk

Outsource all inline scripts and styles #635

Codecov Report