Closed k4rl85 closed 1 year ago
Merging #638 (0dd5a0b) into master (415529c) will increase coverage by
0.08%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #638 +/- ##
==========================================
+ Coverage 86.42% 86.51% +0.08%
==========================================
Files 52 52
Lines 2078 2091 +13
==========================================
+ Hits 1796 1809 +13
Misses 282 282
Impacted Files | Coverage Δ | |
---|---|---|
silk/config.py | 90.47% <ø> (ø) |
|
silk/collector.py | 90.60% <100.00%> (+0.89%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@k4rl85 can you try rebasing this pull request to get the tests to pass?
@albertyw rebased the pr
The aim of this pull request is to generate a more informative profile file name. This would allow us to identify the endpoint that generates a profile file without the need to open it.
To avoid breaking any existent use case I set this behavior behind the setting
SILKY_PYTHON_PROFILER_EXTENDED_FILE_NAME
that by default is disabled.If you think we can change the generated filename without worry we can simply apply this change always without the need to introduce the new settings.