jazzband / django-silk

Silky smooth profiling for Django
MIT License
4.32k stars 332 forks source link

Handle case-insensitive sensitive headers #674

Closed shtimn closed 10 months ago

shtimn commented 10 months ago

fixes #673

codecov[bot] commented 10 months ago

Codecov Report

Merging #674 (d573d5a) into master (25b3191) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   86.51%   86.50%   -0.01%     
==========================================
  Files          52       52              
  Lines        2091     2090       -1     
==========================================
- Hits         1809     1808       -1     
  Misses        282      282              
Files Changed Coverage Δ
silk/model_factory.py 84.47% <100.00%> (-0.08%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

shtimn commented 10 months ago

Hi @albertyw,

I have made some improvements to the handling of sensitive headers in the RequestModelFactory.encoded_headers method. Could you please take a moment to review the changes ?

Thanks!

shtimn commented 10 months ago

@albertyw, I appreciate the merge 😊

Could you please let me know when the new version is scheduled?

albertyw commented 9 months ago

New version will be released with #678