Open fetzig opened 1 month ago
Rendering behaviour of history change_form isn't as expected if has_change_permission == False.
has_change_permission == False
UPDATE: Also fixes the pre-commit-ci job by upgrading to python 3.9.
pre-commit-ci
django Admin renders a "form" full of readonly_fields in this case:
@admin.register(Foo) class FooAdmin(SimpleHistoryAdmin): # ... def has_change_permission(self, request, obj=None): return False
Instead of rendering like the original change_form of Foo (just readonly fields), it renders form fields (input tags). But no submit buttons.
Foo
djangos ModelAdmin adds all fields to ModelAdmin.readonly_fields.
ModelAdmin
ModelAdmin.readonly_fields
This behaviour has been copied ModelAdmin._changeform_view to SimpleHIstoryAdmin.history_form_view.
ModelAdmin._changeform_view
SimpleHIstoryAdmin.history_form_view
An Issue for this already exists: #1362
Getting SimpleHistoryModel to act as expected, which is to be consistent with djangos ModelAdmin.
Comparing of SimpleHistoryModel behaviour with corresponding ModelAdmin and default django-simple-history settings.
pre-commit run
AUTHORS.rst
CHANGES.rst
Rendering behaviour of history change_form isn't as expected if
has_change_permission == False
.Description
django Admin renders a "form" full of readonly_fields in this case:
Instead of rendering like the original change_form of
Foo
(just readonly fields), it renders form fields (input tags). But no submit buttons.djangos
ModelAdmin
adds all fields toModelAdmin.readonly_fields
.This behaviour has been copied
ModelAdmin._changeform_view
toSimpleHIstoryAdmin.history_form_view
.Related Issue
An Issue for this already exists: #1362
Motivation and Context
Getting SimpleHistoryModel to act as expected, which is to be consistent with djangos ModelAdmin.
How Has This Been Tested?
Comparing of SimpleHistoryModel behaviour with corresponding ModelAdmin and default django-simple-history settings.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst