#215 Replace django.core.urlresolvers with django.urls (RemovedInDjango20Warning)

jazzband / django-smart-selects

chained and grouped selects for django forms

https://django-smart-selects.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

1.11k stars 348 forks source link

#215 Replace django.core.urlresolvers with django.urls (RemovedInDjango20Warning) #216

Closed mattayes closed 7 years ago

mattayes commented 7 years ago

Closes #215

Replaces all instances of django.core.urlresolvers with django.urls, as per the recommendation in the Django 1.10 release notes.

I just a try/except block to do the import-choosing. Let me know if you prefer a different approach (if/else, for example).

coveralls commented 7 years ago

Coverage decreased (-1.7%) to 86.957% when pulling ce373a06f7b2aae57532143b645291a138fafcda on mattayes:215-django-urls into 7a5327ed4e1c4981f1e1be2d5452b427e5e09724 on digi604:master.

coveralls commented 7 years ago

Coverage increased (+0.07%) to 88.769% when pulling ebf3634965d149a478e6a77f7613e2a43b23b56a on mattayes:215-django-urls into 7a5327ed4e1c4981f1e1be2d5452b427e5e09724 on digi604:master.

mattayes commented 7 years ago

Closing as this solution is a bit clunky (it's honestly better to just have the warning until django-smart-selects is supporting only Django 1.10+.