search

jazzband / django-smart-selects

chained and grouped selects for django forms
https://django-smart-selects.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1.1k stars 348 forks source link

RemovedInDjango21Warning #278

Closed timthelion closed 4 years ago

timthelion commented 5 years ago

RemovedInDjango21Warning: Add therendererargument to the render() method of <class 'smart_selects.widgets.ChainedSelect'>. It will be mandatory in Django 2.1. [boundfield.py:36]

Changes need to be made here:

https://github.com/digi604/django-smart-selects/blob/master/smart_selects/widgets.py#L217

And here:

https://github.com/digi604/django-smart-selects/blob/master/smart_selects/widgets.py#L83

Here is an example of how to make the change:

https://github.com/adilkhash/django-wysiwyg-redactor/commit/b2c4ca33909ced447f3c1ee9bd01dab14d3a5ac2

@PetrDlouhy

manelclos commented 4 years ago

Hi @timthelion, tried with latest 2.0 and did not see the warning. Tried with 2.1 and it worked. Can you please add more information to this issue?

manelclos commented 4 years ago

@timthelion this has been fixed in https://github.com/jazzband/django-smart-selects/commit/6c00a6b54aeabce771218c07006cca156b3b06e2