jazzband / django-smart-selects

chained and grouped selects for django forms
https://django-smart-selects.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1.1k stars 348 forks source link

Implement Jazzband guidelines for django-smart-selects #286

Closed jazzband-bot closed 3 years ago

jazzband-bot commented 4 years ago

This issue tracks the implementation of the Jazzband guidelines for the project django-smart-selects

It was initiated by @digi604 who was automatically assigned in addition to the Jazzband roadies.

See the TODO list below for the generally required tasks, but feel free to update it in case the project requires it.

Feel free to ping a Jazzband roadie if you have any question.

TODOs

Project details

Description chained and grouped selects for django forms
Homepage
Stargazers 792
Open issues 49
Forks 282
Default branch master
Is a fork False
Has Wiki False
Has Pages False
jezdez commented 4 years ago

I've added an unusual item to the TODO list above: since the project doesn't have a Sphinx setup at the moment, this will have to be done in retrospect.

manelclos commented 4 years ago

@jezdez can anyone open PRs to fix items in the TODO list?

jezdez commented 4 years ago

@manelclos Any member of Jazzband, so as long as you've joined on jazzband.co you're good.

jezdez commented 4 years ago

@digi604 Please let me know if you have any questions.

jezdez commented 4 years ago

@digi604 Hey, please respond.

jezdez commented 4 years ago

To reiterate what I said over in https://github.com/jazzband/django-smart-selects/commit/05dcc4a3de2874499ff3b9a3dfac5c623206e3e5#commitcomment-36254287

Hi all and welcome to Jazzband! Thanks @digi604 for transferring the repo.

Since you haven't opened a ticket or got in touch with the Jazzband roadies (via https://github.com/jazzband-roadies/help) before transferring the repo as is customary, please make sure you more carefully re-read the Jazzband guidelines and the FAQ to familiarize yourself with Jazzband.

There is also a new ticket to track the process of applying the guidelines to this repo. Only when the TODOs in that ticket are done the transfer will be complete. Failing to do so will lead to the deletion of the repo.

You should note that I will delete repos that are not adopting the guidelines and solve the TODO list above. Since you have transferred the repo without prior check I'm eager for someone to get back to me when this will be done.

/cc @manelclos @blag @javierdaza

jezdez commented 4 years ago

The deadline for deletion is 1 week from writing this message.

digi604 commented 4 years ago

jazzband was added to pypi

digi604 commented 4 years ago

But i will not write some docs or setup sphinx. People begged me to hand this over to jazzband. So i did... but further maintenance is currently not possible.

jezdez commented 4 years ago

Thanks @digi604, could you please be more specific who asked you to move it to Jazzband?

It's fair to ask them to port the docs to Sphinx.

manelclos commented 4 years ago

Hi @digi604, thanks a lot for adding jazzband to pypi, I think that was the last detail we cannot handle.

@jezdez I'll take on those tasks, and if @blag want to help he is more than welcome.

I'll take on "Add Sphinx project and move current docs to it".

Thank you all!

manelclos commented 4 years ago

BTW, here is the conversation about moving the project to jazzband: https://github.com/jazzband/django-smart-selects/commit/05dcc4a3de2874499ff3b9a3dfac5c623206e3e5

jezdez commented 4 years ago

Thanks @manelclos!

manelclos commented 4 years ago

@jezdez there is now a PR for adding sphinx to the project. I moved current documentation from README.md and used a markdown plugin, hope that is ok. All sphinx files copied from django-axes to follow Jazzband style.

manelclos commented 4 years ago

@jezdez if there is anything I can do to move this further, please let me know.

manelclos commented 4 years ago

@jezdez ping

manelclos commented 4 years ago

@jezdez it would be great to finish this, currently the README.md file points to Readthedocs but the link is broken. I've merged all PRs so master has the latest code, and in the way of taking care of PRs.

manelclos commented 4 years ago

Hi @digi604, it seems Jazzband itself is suffering the problem it tried to prevent. Could you please add me to pypi while Jazzband chatches up on this?

Thanks!

digi604 commented 4 years ago

added manelclos as a maintainer

jezdez commented 4 years ago

Hey friends, I can't add the needed webhook on the ReadTheDocs side since the jazzband-bot user wasn't added to the Readthedocs project on https://readthedocs.org/dashboard/django-smart-selects/users/. @manelclos @digi604 Can you please fix that?

Have you decided who should be the project lead for this project?

manelclos commented 4 years ago

@jezdez jazzband-bot is now added to Readthedocs. I can be the project lead until-if @digi604 wants to take over, as he stated he can't currently maintain the project.

jezdez commented 3 years ago

Fixed in ab3fd1bd13c2302ce4f847d73f38aba59fc1ff78.