jazzband / django-smart-selects

chained and grouped selects for django forms

https://django-smart-selects.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

1.12k stars 352 forks source link

Remove custom jquery #301

Open leibowitz opened 4 years ago

leibowitz commented 4 years ago

Remove both JQUERY_URL and USE_DJANGO_JQUERY and always use Django jQuery version.

See https://github.com/jazzband/django-smart-selects/pull/270#issuecomment-620387677

BTW, jQuery 2.2.0 is quite old https://snyk.io/vuln/npm:jquery@2.2.0

leibowitz commented 4 years ago

Fun fact, to actually make sure django jQuery is loaded, one needed to set JQUERY_URL = None, otherwise this never enters: https://github.com/jazzband/django-smart-selects/blob/fec2209d940c2894aec7db0a37cd74b19d4df6a1/smart_selects/widgets.py#L37 But I can't see this documented anywhere. Apparently JQUERY_URL = None was the default for a while, and then got changed. I can only see some comments about this in there https://github.com/jazzband/django-smart-selects/issues/206...

manelclos commented 4 years ago

@leibowitz I would like to merge this one. Could you please rebase it against master to fix the conflict?

codecov[bot] commented 3 years ago

Codecov Report

Merging #301 (e66769b) into master (2cff847) will decrease coverage by 12.53%. The diff coverage is 20.00%.

@@             Coverage Diff             @@
##           master     #301       +/-   ##
===========================================
- Coverage   80.42%   67.88%   -12.54%     
===========================================
  Files           8        8               
  Lines         470      464        -6     
  Branches       68       65        -3     
===========================================
- Hits          378      315       -63     
- Misses         60      136       +76     
+ Partials       32       13       -19

Impacted Files	Coverage Δ
smart_selects/widgets.py	`31.97% <20.00%> (-34.32%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2cff847...e66769b. Read the comment docs.

leibowitz commented 3 years ago

@manelclos happy to try to bring this PR/branch up-to-date, if you are still willing to merge it? I did update it a year ago but nobody seems to have been bold enough to merge. I guess there were some concerns?

In my opinion depending on jquery 2.2.0 is not ideal. Especially since django already bundles jquery... I don't really see the need. Also, this causes a myriad of issues with other django extensions, I'm not going to get into... mainly due to events not being triggered due to multiple versions of jquery being loaded

manelclos commented 3 years ago

Hi @leibowitz, back then I wanted to merge simple PRs to have a "last" compatible release, then merge this and the one removing Django 2.2 support to have a new major version release. But the Django 2.2 PR was merged without prior notice.

This PR was ok, I'm happy to look at it again if you update it. We should look into other needed modifications before we bump the major version.